tcm390

Results 85 comments of tcm390

[disable audio worker after grunt end](https://github.com/webaverse/app/pull/3651/commits/2d7e702001a61e38479d372ce4a6d6b00aae6787) Can we disable audio worker after the grunt effect is completed? > If volume goes from 1 -> 0 in one frame won't this...

> > Can we disable audio worker after the grunt effect is completed? > > No I don't think that's right, creating/destroying workers is a pretty heavy operation to run...

> And if this is related to `manuallySetMouth`, shouldn't both be in the same class? Currently it's spread around so the code is confusing to read. [disable audioworker set volume...

> It looks like this is still using the `disable` name: https://github.com/webaverse/app/pull/3651/files#diff-fcb2093ac11d9b04a179d3dedbef5c0aae4d14b7f71db90e483becca4170b7ccR2041 Sorry Changed it. [change disableAudioWorkerSetVolume to enableAudioWorkerSetVolume](https://github.com/webaverse/app/pull/3651/commits/82d734e63e5371d383d5c3a6ea61399211339287)

> @tcm390 would you do some code cleanup? [clean code](https://github.com/webaverse/app/pull/3581/commits/00da48541b54570644d38f8ee2a280d78624a0ca)

[maintain user previous facial expression](https://github.com/webaverse/app/pull/3403/commits/dea3d4bcbcbad515d069a496ca05f8618c5ab407) Result: https://user-images.githubusercontent.com/60634884/182469129-381e6f68-2a40-45dd-8dff-033ad8f44aef.mp4

https://github.com/webaverse/app/issues/2769#issuecomment-1097249349 I think the problem could be solved by setting `depthWrite: false` to the shield material

because NPC player is updated twice each frame related: https://github.com/webaverse/app/issues/3568

Shield has higher priority than sonic boom. ![priority](https://user-images.githubusercontent.com/60634884/163057874-2d2a586d-5368-4a96-92f0-df0d4f47e2bf.png) So the shield would draw on top of sonic-boom, ki, street shader (usually, street and shield have the same priority) ![image](https://user-images.githubusercontent.com/60634884/163057982-bab7b679-bf4b-424e-bf64-4a4ad81f1b11.png) https://user-images.githubusercontent.com/60634884/163058031-af23f858-18a1-4e1c-b9f4-61ea4435f7a9.mp4...

Result current App | Resize | :-------------------------:|:-------------------------: ![image](https://user-images.githubusercontent.com/60634884/182963580-c3373d7e-e920-48c7-bcfb-411be3d575e0.png)| ![image](https://user-images.githubusercontent.com/60634884/182963593-22089ee7-8420-453f-aa05-4f243d124ca1.png) ![image](https://user-images.githubusercontent.com/60634884/182963661-91c46f5b-60c4-4652-bdcc-a0db1d8a5a6b.png)|![image](https://user-images.githubusercontent.com/60634884/182963671-70b86058-3702-4ae0-8dcf-a1acdd01d653.png) ![image](https://user-images.githubusercontent.com/60634884/182963681-9872e924-e044-4cd1-bdd6-5cdcc8e66179.png)|![image](https://user-images.githubusercontent.com/60634884/182963686-83ca8c39-9a5f-4329-9f98-bcc2d6311d08.png) ![image](https://user-images.githubusercontent.com/60634884/182963689-e0cddf0f-606b-4f3d-ab2b-014425e29dd5.png)|![image](https://user-images.githubusercontent.com/60634884/182963695-2e72033f-560e-4f4a-8575-543c04b4a957.png) ![image](https://user-images.githubusercontent.com/60634884/182963704-7864f20c-bfc0-4d9b-9cf4-c6aa7e05420d.png)|![image](https://user-images.githubusercontent.com/60634884/182963714-0d0f5c8e-8775-4ddf-b86e-4443f6743269.png) ![image](https://user-images.githubusercontent.com/60634884/182963724-29f435fc-f595-4f47-bf55-cf5789738fba.png)|![image](https://user-images.githubusercontent.com/60634884/182963732-6ea05deb-6f0d-4fcc-b3ea-13562b77cf50.png) ![image](https://user-images.githubusercontent.com/60634884/182963740-481d6fc9-c0f1-4f25-9b24-913c41ab0097.png)|![image](https://user-images.githubusercontent.com/60634884/182963746-19de1763-03d7-4070-a59a-4847229a82d7.png) ![image](https://user-images.githubusercontent.com/60634884/182963755-a0e1d9ef-5f3c-4fed-a22a-8a067ab7b178.png)|![image](https://user-images.githubusercontent.com/60634884/182963762-4462bd06-6036-4126-979f-b944aab3f492.png) ![image](https://user-images.githubusercontent.com/60634884/182963775-a53b83e7-2e42-40fa-9b0c-c2d268d0f81f.png)|![image](https://user-images.githubusercontent.com/60634884/182963778-8b429fa0-3612-438e-a849-733c306fc013.png) ![image](https://user-images.githubusercontent.com/60634884/182963787-6988dd24-9d5e-4be5-af04-ecadba640dab.png)|![image](https://user-images.githubusercontent.com/60634884/182963792-79ef5d79-656c-4bf4-8192-9008bf1be68d.png) ![image](https://user-images.githubusercontent.com/60634884/182963803-a0b88cc3-0a2d-4db8-b7df-9f36c747da14.png)|![image](https://user-images.githubusercontent.com/60634884/182963811-1b6364d3-8071-47b2-a772-9871e2a5f715.png) ![image](https://user-images.githubusercontent.com/60634884/182963821-eed25398-f39b-4593-884e-d67dc639bf6c.png)|![image](https://user-images.githubusercontent.com/60634884/182963829-9fdeb88b-3239-4213-968e-67b88722287c.png) ![image](https://user-images.githubusercontent.com/60634884/182963842-37513b5f-b7f2-4b12-9f3c-0b6549d38ed4.png)|![image](https://user-images.githubusercontent.com/60634884/182963847-5653424b-e85e-40d7-8730-fec708a97236.png) ![image](https://user-images.githubusercontent.com/60634884/182963856-31c20fc4-c56e-48ba-9ef0-d572b58103a9.png)|![image](https://user-images.githubusercontent.com/60634884/182963862-14b7c3da-202d-4150-82bf-021d25f4aeec.png) ![image](https://user-images.githubusercontent.com/60634884/182963872-540573bc-c830-4eae-92ed-b45850755914.png)|![image](https://user-images.githubusercontent.com/60634884/182963880-25bf0074-9cae-4dbd-b767-41ff111e5fbd.png) ![image](https://user-images.githubusercontent.com/60634884/182963885-178cdc4f-92ca-43b2-863c-d36fbcbc0485.png)|![image](https://user-images.githubusercontent.com/60634884/182963895-57c6818c-5b57-4c3e-a063-6efc16996b6b.png) ![image](https://user-images.githubusercontent.com/60634884/182963904-361f0848-950b-4683-84f5-313f6561fd21.png)|![image](https://user-images.githubusercontent.com/60634884/182963914-50aa8568-3cda-404e-834c-ff634f8ca33e.png) ![image](https://user-images.githubusercontent.com/60634884/182963921-b0b32b68-add7-4c39-bc03-df2229e9a93f.png)|![image](https://user-images.githubusercontent.com/60634884/182963927-24ef6969-d81d-4483-9545-73f8ad4c5f5c.png) ![image](https://user-images.githubusercontent.com/60634884/182963936-7fba72b9-23b6-49b5-a090-9daa3e4f5789.png)|![image](https://user-images.githubusercontent.com/60634884/182963945-0d14b6f1-bd97-4210-8cff-be5e59019a79.png) ![image](https://user-images.githubusercontent.com/60634884/182963953-7b18f8bf-b400-43a4-a42b-091de20c7dba.png)|![image](https://user-images.githubusercontent.com/60634884/182963963-c07f5d28-c012-4359-a8a9-1068a35f6ca7.png) ![image](https://user-images.githubusercontent.com/60634884/182963970-d047573f-6b1c-499e-aeba-e81cee6fccf1.png)|![image](https://user-images.githubusercontent.com/60634884/182963979-be70e8ac-fbf9-4565-b1d1-1c4e4d8af9e9.png) ![image](https://user-images.githubusercontent.com/60634884/182963982-8b964e71-a691-4582-a019-aa490384fd95.png)|![image](https://user-images.githubusercontent.com/60634884/182963991-821739e3-4921-46e4-9f9c-b8ce18965b37.png)...