Tim Ledbetter
Tim Ledbetter
This change LGTM. I also had a go at fixing this. I've just submitted my own PR (#23132) which fixes PixelPaint, so that it doesn't try to add an empty...
Thanks for the very helpful review! I've updated the PR to fix the issues you highlighted.
My latest push replaces the `HashTable` I was using with an `OrderedHashTable`. This ensures that member entries in `/etc/group` appear in the same order that we specify on the command...
> Note that the CodingStyle document says braces around single-line if statements is OK, and not wrong. :) So it does! I'll be sure to refer back to it in...
My latest push ensures that all references to a user in `/etc/group` are removed when the user is deleted (with the `userdel` command, for example). This matches the behavior on...
I've made a PR which changes the multiple inline code blocks in the `checksum` man page to a single multi-line code block. This renders correctly as HTML as well as...
My latest push updates the PR to ensure that code blocks of the form ```` ```**foo This should be bold ``` ```` are displayed with a bold font in the...
My latest push reverts this PR to its original form, which just modifies the formatting of the `checksum` man page. More work is needed to support styles correctly, which I...
I believe that these lines are causing the `:before` element to not be displayed: https://github.com/SerenityOS/serenity/blob/83ab9f7c2dbe4bc9b96a9d75a371cee4ebf40b71/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp#L427-L428 And this line may be what is causing the `:after` element to be displayed incorrectly:...
Sorry, I didn't see your PR before I made mine! I don't think this correctly handles the case where `-p` is used and the template is a directory. For example:...