Tim Ledbetter

Results 96 comments of Tim Ledbetter

This change yields improvements in these WPT tests: * http://wpt.live/css/css-color/parsing/color-computed.html * http://wpt.live/css/css-color/parsing/color-valid-hsl.html * http://wpt.live/css/css-color/parsing/color-valid-rgb.html * http://wpt.live/css/css-color/parsing/color-valid.html * http://wpt.live/css/css-color/parsing/color-computed-hsl.html (this one is probably a little too slow for CI) Is it...

My latest push adds the arithmetic filter, but I'm still getting a some color differences compared to other browsers. I've tested the arithmetic filter with the following SVG: ```html ```...

I think you're right, the difference appears to be a linear RGB -> sRGB conversion from the application of the [`color-interpolation-filters` property](https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/color-interpolation-filters), which has a default value of `linearRGB`. If...

> the color space issues could be taken care of separately? (a todo somewhere would be enough?) I have an implementation of `color-interpolation-filters`, which corrects the color difference, but it...

Sorry it took me a while to get back to this. On my machine, the hover label currently overlaps the edge of the window - or the find in page...

Closing, as the provided reduction now behaves as expected.

When I initially tested this I saved the reduction with a `.html` extension. This works as expected. Saving with a `.svg` extension causes the rendering to be incorrect.

> Is this testable through `document.getSelection()`? I think to test this I'd need to simulate selecting text with the mouse, since the offending code path is only taken in `Page/EventHandler.cpp`...

When running this test in Linux with the Debug preset, I frequently get a crash with this stack trace: ``` #0 sk_abort_no_print () at ../src/335264b559-747e4e3c5f.clean/src/ports/SkMemory_malloc.cpp:60 #1 0x00007e5ec8c6a70b in skgpu::SingleOwner::enter(char const*,...