Taiwon Chung comments

Repositories
Issues
Comments

Results 6 comments of


                                            Taiwon Chung

Private Provides

Internal Ref: GO-1736

deadlock when use with lumberjack in multi goroutine

Could you provide a specific repro for this issue?

fx.OnStart, fx.OnStop doesn't work with named dependencies (using fx.ResultTags)

Hey, sorry I missed this. Yeah, I think making it less verbose could be a valid improvement on this (as a syntactic sugar), but meanwhile we can probably close this...

adds fx.From annotation

This has been completed with #990.

Intercept provided values

I agree with @JacobOaks that this is probably fine, but we should clearly document that those values in `CallbackInfo` shouldn't be modified.

Intercept provided values

Before we add a whole new top-level API for registering a global callback for all providers, could you consider adding the constructed values into CallbackInfo? I think it would be...