fx icon indicating copy to clipboard operation
fx copied to clipboard

adds fx.From annotation

Open rossb83 opened this issue 2 years ago • 2 comments

Adds fx.From annotation to allow injecting struct ptr types for interface dependencies which they implement. This should address issue https://github.com/uber-go/fx/issues/878

rossb83 avatar Sep 21 '22 03:09 rossb83

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '22 03:09 CLAassistant

Codecov Report

Merging #938 (3c178f4) into master (f8aaaeb) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   98.72%   98.74%   +0.01%     
==========================================
  Files          30       30              
  Lines        1337     1357      +20     
==========================================
+ Hits         1320     1340      +20     
  Misses         11       11              
  Partials        6        6              
Impacted Files Coverage Δ
annotated.go 99.71% <100.00%> (+0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 21 '22 06:09 codecov[bot]

ping @rossb83 😊 LGTM

kkHAIKE avatar Nov 10 '22 09:11 kkHAIKE

This has been completed with #990.

tchung1118 avatar Dec 23 '22 20:12 tchung1118