Toni Cárdenas

icon indicating a website link https://tcardenas.me icon indicating an email [email protected]

icon location Madrid, Spain

Results 5 comments of Toni Cárdenas

Support for receiver-side browser push notifications.

Missing: * Ably's application server key is currently hardcoded. Probably needs to be served. https://github.com/ably/ably-js/blob/183a62dd7cb381262ad884677d126a966c8cb64e/browser/fragments/platform-browser.js#L77 * Safari support. See https://github.com/ably/wiki/issues/242 https://github.com/ably/ably-js/blob/183a62dd7cb381262ad884677d126a966c8cb64e/browser/fragments/platform-browser.js#L123 * Form factor needs to be detected. https://github.com/ably/ably-js/blob/183a62dd7cb381262ad884677d126a966c8cb64e/browser/fragments/platform-browser.js#L30 *...

Support for receiver-side browser push notifications.

Also, PushChannel is not implemented at all.

RTN13: Connection.ping

@sacOO7 It is implemented: https://github.com/ably/ably-go/blob/270df167833b9c5f82917a5bee2c1bd6fa421977/ably/realtime_conn.go#L468

RTN13: Connection.ping

Ah OK, sorry, I thought you meant it's not there at all. Since it is exposed, it needs to have a spec-compliant API at least, or just removed entirely for...

Question: Should the Logger be static

Alternatively, methods on `Message` and friends could be moved to the classes acting on them (ie. `AblyRest/Realtime` and its auxiliary classes) so that they're left just holding the data as...