ably-go icon indicating copy to clipboard operation
ably-go copied to clipboard

RTN13: Connection.ping

Open ably-sync-bot opened this issue 4 years ago • 4 comments

Write spec tests for RTN13, ensure they pass and that the affected API conforms to the 1.2 API design.

┆Issue is synchronized with this Jira Task by Unito

ably-sync-bot avatar Nov 13 '20 17:11 ably-sync-bot

Connection Ping function is not implemented, need to implement and then write tests for it

sacOO7 avatar Mar 11 '21 20:03 sacOO7

@sacOO7 It is implemented: https://github.com/ably/ably-go/blob/270df167833b9c5f82917a5bee2c1bd6fa421977/ably/realtime_conn.go#L468

tcard avatar Mar 20 '21 08:03 tcard

@tcard if you look carefully, it returns new error with todo

https://github.com/ably/ably-go/blob/270df167833b9c5f82917a5bee2c1bd6fa421977/ably/realtime_conn.go#L468-L476

sacOO7 avatar Mar 20 '21 17:03 sacOO7

Ah OK, sorry, I thought you meant it's not there at all.

Since it is exposed, it needs to have a spec-compliant API at least, or just removed entirely for the moment.

tcard avatar Mar 23 '21 07:03 tcard