Théis Bazin

Adds minimal TypeScript types

1

Also provides AudioKeys as a named export to enable TypeScript [module augmentation](https://www.typescriptlang.org/docs/handbook/declaration-merging.html#module-augmentation).

Hi! Thanks a lot for this library! 😃 Here's a PR to make it international! 🗺️ - Adds a `layoutIndependentMapping` option to use the layout-independent `'code'` key identifier in keyboardEvents...

Fixed by #8

Add initial TypeScript type declarations

1

Hi! Here's a first proposition for bundled TS type declarations. It's probably not perfectly clean, I wasn't sure what to do with private class methods for instance, and ultimately I...

Provide TypeScript .d.ts type declarations

1

Would you accept a PR providing TypeScript type declarations for the package? I have an initial version of those that I could contribute to the repo! Alternately, I could add...

Change first state's feature / symbol

3

I think having (for all newly created `oracle`) `oracle.symbol[0] == None` rather than `oracle.symbol[0] == 0` would make more sense. What do You think about it?

Renaming oracle attributes

2

I find the name `data` to be confusing in the oracle's class attributes. I'd rather go for `symbols` instead, to clearly distinguish it from the concrete data, the features. With...

Some questions about suffix_method

1

@wangsix : the `MO` class offers a parameter `suffix_method` (currently with two recognized values, `'inc'` and `'complete'`), `VMO` and `FO` don't support it. Where is this parameter introduced? Is it...

Code replication in module oracle.py

5

The codes for classes `FactorOracle`, `MO` and `VMO` are all very close and share many identical lines, making it hard to uniformly update it. This could probably be fixed by...

Hi! I was browsing through the forum and I saw this post: https://groups.google.com/g/tonejs/c/sNwjqEIxa7g, in which the author of the Custom Piano Keys demo were asking for an update of the...