Théis Bazin

Results 7 comments of Théis Bazin

Thank you very much for the review @j127! To be honest, it's been a while since I last used the library so I'm not completely 100% about the quality of...

I've just done it in the dev branch, I'll merge it with master in the coming days. I actually went for `symbol` instead of `symbols`, since all transitions leading to...

Yes, I can see that. But changing it to `None` actually **doesn't** pose a problem when doing such a cast (since Python's lists and arrays don't have a single-type content...

Alright, it _does_ actually mess up the codebase, You were right. And then again, the typing system in Python being what it is, Your way of seeing things also makes...

I'm currently looking at it to see to which extent we can take advantage of the inheritance mechanism to simplify everything. Might not be super easy, but it'll save us...

For starters, I think the function `add_state` should be modified to be uniform across all implementations. What really differs between the different versions is the way distances between data are...

Have it become an explicit function within the base class `FactorOracle`, with an implementation shared by all subclasses (this would find the lrs, the transitions, etc. based on purely comparing...