Taylor King comments

Results 6 comments of


                                            Taylor King

Security block has to be repeated on api and tenant scope

Additionally, ``` { "managedUrl": "http://0.0.0.0:8080/api/8e7315c3-bf66-4ec3-9157-c725f1c572d8/v2", "tenantId": "8e7315c3-bf66-4ec3-9157-c725f1c572d8", "id": "8ecf6f30-709f-49a7-8901-46eed0cfeb45", "basePath": "/v2", "name": "test", "resources": { "/die": { "operations": { "GET": { "backendUrl": "https://apim-banka.mybluemix.net/banka/v1/branches", "security": { "type": "apikey", "secret": "true", "scope":...

Need end to end tests

@ddragosd @mhamann @alexsong93 How are we going to do this? Should I use the existing busted stuff or should I do some kind of thing with container orchestration to spin...

Need end to end tests

I have made some progress on this, I wanted to get my ICLA in and get some input from @dragosd

Improve performance by adding a 2 layered cache

Awesome thank you

For the identity propagation, used a signed JWT to carry the credential downstream

Now that we have JOSE in here it might be cool to sign our own tokens so the backend could verify a request was coming from a gateway.

Exit gracefully on SIGINT

I tried the code review bots suggestion, but it didn't fix the problem and still blocks stopping the service https://stackoverflow.com/questions/14626636/how-do-i-shutdown-a-node-js-https-server-immediately I think server.close() just stops the server accepting new connections...