RTL icon indicating copy to clipboard operation
RTL copied to clipboard

Published 20 hours ago • verified publisher icon Ride-The-Lightning

Exit gracefully on SIGINT

Open taylorking opened this issue 1 year ago • 2 comments

I am trying to run this in docker under systemd and was getting failures trying to restart the job. Before ctrl + c would not kill the task successfully when running under docker, this fixes that as well.

Summary by CodeRabbit

  • Chores
    • Improved process termination handling on user interrupt signals.

taylorking avatar Feb 15 '24 00:02 taylorking

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The update enhances the application's robustness by adding a 'SIGINT' process event listener in rtl.js to enable graceful process exit upon receiving an interrupt signal. It also includes minor adjustments to variable assignments for improved efficiency.

Changes

File(s) Change Summary
rtl.js Added a process event listener for 'SIGINT' to exit the process and made minor adjustments to variable assignments.

🐇✨
In the realm of code, where rabbits play,
A new charm's cast, without delay.
'SIGINT' caught, the app shall rest,
With variables tweaked, for the very best.
So hop along, on this code crusade,
Where bugs are caught and magic's made.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Feb 15 '24 00:02 coderabbitai[bot]

I tried the code review bots suggestion, but it didn't fix the problem and still blocks stopping the service

https://stackoverflow.com/questions/14626636/how-do-i-shutdown-a-node-js-https-server-immediately

I think server.close() just stops the server accepting new connections but keeps alive any existing connections.

Anyways, up to you if you want to accept this change. I am using it to run RTL in systemd in docker.

taylorking avatar Feb 16 '24 00:02 taylorking