Michaël Zasso

Results 1686 comments of Michaël Zasso

SGTM as long as we have the budget for it and it is not abused.

Here's a first test run: https://github.com/nodejs/citgm/actions/runs/7466807218

CI doesn't run `citgm-all`. It takes too long and must be run manually.

https://github.com/nodejs/citgm/actions/runs/7466807218

OK, let's do a full run in Jenkins.

v18: https://ci.nodejs.org/job/citgm-smoker-nobuild/1579/ v20: https://ci.nodejs.org/job/citgm-smoker-nobuild/1580/ v21: https://ci.nodejs.org/job/citgm-smoker-nobuild/1581/

`pnpm` is not installed on CI hosts. It's a dependency of the `citgm` package: https://github.com/nodejs/citgm/commit/46d35aef9057c081c8a04cbe9f01cdf1df72112f

I would say that the actual bug is that we download the wrong binary.

Can this be fixed in `through2`? I doubt it actually needs puppeteer for its test. To answer your question, I don't know if that's the intended way, but it seems...