Michaël Zasso

Results 1686 comments of Michaël Zasso

Is https://ci.nodejs.org/job/node-test-commit-v8-linux/4882/ the new run? It failed with `18:19:57 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?`

Here's a run for https://github.com/nodejs/node/pull/44741 https://ci.nodejs.org/job/node-test-commit-v8-linux/4887/

> I'm not sure what's up with the benchmark machine -- it looks like issues fetching V8 dependencies stretching back over a week (i.e. before any of these changes). Can...

Just trying again: https://ci.nodejs.org/job/node-test-commit-v8-linux/4889/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/

> we should probably spin this discussion out to a separate issue as it's not really anything to do with this PR I agree, this is an infra issue and...

Should we keep this issue open? If not, what concrete actions can we take before closing it?

@LiviaMedeiros I cherry-picked https://github.com/nodejs/node/pull/43714 and this commit to v16.x-staging but it doesn't seem to work as expected. See https://github.com/nodejs/node/pull/44542#issuecomment-1249141515 https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

FWIW I published [dialog-polyfill-universal](https://www.npmjs.com/package/dialog-polyfill-universal) for SSR compatibility.

@jdalton You can see the failing modules here: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1878/nodes=fedora-latest-x64/ citgm.clinic-v4.1.0 citgm.fastify-v2.5.0 citgm.semver-v6.1.1 citgm.split2-v3.1.1

Is there a path to fix this? I don't want to hold https://github.com/nodejs/node/pull/21387 out of v12.x for too long.