Michaël Zasso

Results 1686 comments of Michaël Zasso

I don't know how it's implemented but I would expect that each Node.js thread (main and workers) has its own separate loaders thread, at least for two reasons: - Worker...

What remains to be done?

There's a lot of CI failures but I don't understand how I broke it.

Other errors seem to be https://github.com/nodejs/build/issues/3037

Rebased to update to patch version 11 (see https://github.com/v8/v8/commits/10.7-lkgr)

@pbo-linaro I'm seeing linker errors on arm64 Windows ``` 14:53:29 v8_base_without_compiler_host.lib(api.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::TryHandleWasmTrap(struct _EXCEPTION_POINTERS *)" (?TryHandleWasmTrap@trap_handler@internal@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) referenced in function "bool __cdecl v8::TryHandleWebAssemblyTrapWindows(struct _EXCEPTION_POINTERS...

> Those functions were implemented in [this](https://chromium-review.googlesource.com/c/v8/v8/+/3913036) patch (merged upstream). > > Patch you mention can probably be deleted (with updated v8), as functions are now implemented. That's what I...

It was my bad. I forgot to update v8.gyp (the files defining the missing symbols were not included in the build).

Fixed (I hope) in https://github.com/nodejs/node/pull/44741/commits/d21c398826546661acce7d60cc33d1b73a2abd4f

It looks like there is an issue with native addons on Windows?