node
node copied to clipboard
nodejs
deps: update V8 to 10.7
WIP.
This includes 4 temporary commits to fix known issues. Those still need to be upstreamed or landed on main
Closes: https://github.com/nodejs/node/issues/44650
At least one of the machines is failing with this error:
12:11:57 error: The last gc run reported the following. Please correct the root cause
12:11:57 and remove .git/gc.log.
I.e., infrastructure error.
CI: https://ci.nodejs.org/job/node-test-pull-request/46811/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4876/
Rebased to update to patch version 11 (see https://github.com/v8/v8/commits/10.7-lkgr)
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4881/ (with changes to use the new converter for JUnit output https://github.com/nodejs/node/pull/44049#issuecomment-1261117494)
@pbo-linaro I'm seeing linker errors on arm64 Windows
14:53:29 v8_base_without_compiler_host.lib(api.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::TryHandleWasmTrap(struct _EXCEPTION_POINTERS *)" (?TryHandleWasmTrap@trap_handler@internal@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) referenced in function "bool __cdecl v8::TryHandleWebAssemblyTrapWindows(struct _EXCEPTION_POINTERS *)" (?TryHandleWebAssemblyTrapWindows@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:53:31 v8_base_without_compiler_host.lib(handler-outside.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::RegisterDefaultTrapHandler(void)" (?RegisterDefaultTrapHandler@trap_handler@internal@v8@@YA_NXZ) referenced in function "bool __cdecl v8::internal::trap_handler::EnableTrapHandler(bool)" (?EnableTrapHandler@trap_handler@internal@v8@@YA_N_N@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:53:31 v8_base_without_compiler_host.lib(simulator-arm64.obj) : error LNK2019: unresolved external symbol ProbeMemory referenced in function "protected: void __cdecl v8::internal::Simulator::LoadStoreHelper(class v8::internal::Instruction *,__int64,enum v8::internal::AddrMode)" (?LoadStoreHelper@Simulator@internal@v8@@IEAAXPEAVInstruction@23@_JW4AddrMode@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:53:31 Hint on symbols that are defined and could potentially match:
14:53:31 "protected: bool __cdecl v8::internal::Simulator::ProbeMemory(unsigned __int64,unsigned __int64)" (?ProbeMemory@Simulator@internal@v8@@IEAA_N_K0@Z)
14:53:31 ..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 3 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
Should I still float the patch from https://github.com/nodejs/node-v8/commit/26c8df37b3b665780f8c28a10cb4c5eb3ddc5303 ?
Those functions were implemented in this patch (merged upstream).
Patch you mention can probably be deleted (with updated v8), as functions are now implemented.
Those functions were implemented in this patch (merged upstream).
Patch you mention can probably be deleted (with updated v8), as functions are now implemented.
That's what I did (delete the patch). This PR contains the V8 change:
It was my bad. I forgot to update v8.gyp (the files defining the missing symbols were not included in the build).
Fixed (I hope) in https://github.com/nodejs/node/pull/44741/commits/d21c398826546661acce7d60cc33d1b73a2abd4f
CI: https://ci.nodejs.org/job/node-test-pull-request/46917/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4887/
It looks like there is an issue with native addons on Windows?
https://ci.nodejs.org/job/node-test-binary-windows-native-suites/14819/nodes=win2012r2-vs2015-COMPILED_BY-vs2019-x86/console
13:16:10 "c:\\workspace\\node-test-binary-windows-native-suites\\node\\deps\\v8\\include\\v8-internal.h(461): error C2143: syntax error: missing ',' before ')' [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\addons\\01_worker_support\\build\\addon.vcxproj]\r\n" +
CI: https://ci.nodejs.org/job/node-test-pull-request/47044/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4894/
[Error: ENOSPC: no space left on device, ftruncate] {
🤦
The VS 2015 add-on build issue still exists. I'm okay with dropping VS 2015 support, that's seven years old now.
CI: https://ci.nodejs.org/job/node-test-pull-request/47152/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4903/