Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

Upgrade github-bot server

I don't know. We need someone who has the time, knowledge, and infra access to do the changes.

feat(git-node): add release promotion step

Thanks for working on this! I will try it the next time I make a release.

feat(git-node): add release promotion step

So, I tried the command for v20.18.0. Unfortunately, I didn't go far. At some point it tried to update my local staging branch from upstream but it was already pushed...

feat(git-node): add release promotion step

It is v20.x-staging, which is normal from my pov. I work on a v20.x release in my v20.x workspace

feat(git-node): add release promotion step

I believe it's for backport PRs, but I'm not sure.

feat(git-node): add release promotion step

LGTM

Release GHA does not trigger GHA CI

https://github.com/nodejs/node/pull/58226 was opened by the workflow and triggered the workflows.

Release GHA does not trigger GHA CI

Seems to be working as intended to me.

build,deps,tools: prepare to update to OpenSSL 3.5

I tried the update script again with the changes from this PR on my fork: https://github.com/targos/node/pull/27 Workflow run: https://github.com/targos/node/actions/runs/15186079568 It does the job fine without https://github.com/nodejs/node/pull/58099

build,deps,tools: prepare to update to OpenSSL 3.5

^ Which makes sense now that I think about it again. The "Regenerate platform specific files" step has access to the files even though they are ignored by git. I'm...