Michaël Zasso
Michaël Zasso
It seems unlikely. We found recently that newer V8 versions require it for `__atomic_compare_exchange `
What could be accepted more easily is a new `configure` flag to disable it.
The added test seems very flaky. For example https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/47103/testReport/junit/(root)/parallel/test_abortsignal_drop_settled_signals/
You're right. In this example the failure is in `drops settled dependant signals when signal is composite`. We should probably revert if we don't find a fix quickly
I think we should keep the duplication. I don't like very much the idea that we need to parse something to get/display information from the state.
I'm not aware of any reason that would prevent this behavior.
Draft because Immer v11 changed how it does the auto-freezing and now it fails because typed arrays cannot be frozen.
Nice! I suggest you upstream https://github.com/nodejs/node-v8/pull/288/commits/40548f80a3e81ab0e2417f3999b3d8add49d6a9e. It makes sense to include vector if vector is used in the file.
Found another issue in Xcode 13: https://github.com/nodejs/node/pull/54077#issuecomment-2274947865
It turns out we also need https://github.com/nodejs/node-v8/pull/288/commits/c21cbdffd8dd0937394b5f931f445b5fa0e97cbc for Xcode 13: https://ci.nodejs.org/job/node-test-commit-osx/60282/nodes=osx11-x64/console