deps: fix V8 compilation on Apple clang 13 & 14

[joyeecheung]

[joyeecheung]

The third commit fixes the osx11 failure in https://github.com/nodejs/node/pull/54077 . Second commit is only present in canary for now. Not sure about the first one, looks recent.

[joyeecheung]

cc @targos

[targos]

Nice! I suggest you upstream https://github.com/nodejs/node-v8/pull/288/commits/40548f80a3e81ab0e2417f3999b3d8add49d6a9e. It makes sense to include vector if vector is used in the file.

[lemire]

Current LLVM on Apple platforms is version 15, released in 2023. Version 16 is in its 5th beta and should enter soon RC1.

[joyeecheung]

Uploaded the third commit to https://chromium-review.googlesource.com/c/v8/v8/+/5771451 and the first to https://chromium-review.googlesource.com/c/v8/v8/+/5771471 (not 100% sure about the second commit yet, it fixes the bug but maybe I should simplify it..)

[targos]

Found another issue in Xcode 13: https://github.com/nodejs/node/pull/54077#issuecomment-2274947865

[targos]

It turns out we also need https://github.com/nodejs/node-v8/pull/288/commits/c21cbdffd8dd0937394b5f931f445b5fa0e97cbc for Xcode 13: https://ci.nodejs.org/job/node-test-commit-osx/60282/nodes=osx11-x64/console

[targos]

I included https://chromium-review.googlesource.com/c/v8/v8/+/5771451 and https://chromium-review.googlesource.com/c/v8/v8/+/5771471 in https://github.com/nodejs/node/pull/54077

[targos]

Since we increased the minimum Xcode to 16, I think this can be closed?

[joyeecheung]

Yes