Tony Arcieri
Tony Arcieri
There are valid uses of that enum without the associated crate features, such as the ability to simply parse and serialize such keys without the associated cryptographic operations. I suppose...
If you can help make our implementation RFC9382 compliant, great
@LesnyRumcajs needs a rebase
Thanks for rebasing. This is a very large PR which makes it difficult to review. Another issue is we'd like to replace the entire BLAKE2 implementation: #228
> Do we even want to allow const fn to do something like this? Or do we want to guarantee the property that const fn behave the same at runtime...
Intrinsics would cover probably 99% of our use cases, but there are still gaps, like ADX (and MULX to avoid clobbering ADX flags), which last I checked LLVM doesn't support...
cc @bifurcation I don't think it was deliberate. Sounds like a missing optimization.
Aah sorry! Should've cc'd @tjade273
We expose the compression functions in the `sha2` crate so IMO this is conceptually fine
@kevaundray we've long planned to completely replace the implementation: https://github.com/RustCrypto/hashes/pull/228. Unfortunately that PR has long gone by the wayside.