Tony Arcieri
Tony Arcieri
I've opened a PR to add `EdwardsPoint::compress_batch` (which internally uses `FieldElement::batch_invert`) in #759. It should afford a fairly significant speedup.
I'd first be curious if there are ways to improve the stack usage that don't involve heap offload. Consuming 1MB of stack seems like quite a bit to me right...
https://github.com/WebAssembly/WASI/blob/main/docs/Capabilities.md
Moving to verification only, possibly placing signing under a `hazmat` feature, seems like a reasonable approach to me
It's fine to gate the tests on the corresponding feature. They won't work unless the feature is enabled.
You can also feature gate the examples. Here's an example of a pattern we use to do this: https://github.com/RustCrypto/SSH/blob/f741cf0/ssh-key/src/lib.rs#L44-L45
You can use [`required-features` in Cargo.toml](https://doc.rust-lang.org/cargo/reference/cargo-targets.html#the-required-features-field) for that
@stevefan1999-personal it looks like there are conflicts with `master` that need to be resolved
Aah, looks like that was accidentally removed in RustCrypto/elliptic-curves#1378. I can add it back. Edit: opened https://github.com/RustCrypto/elliptic-curves/pull/1435
I would definitely be a fan of splitting this up into smaller, more focused PRs. It's hard to review in the current form, and there is already so much discussion...