Tony Arcieri

Results 2545 comments of Tony Arcieri

@dishmaker we could consider making the allocating structure `Cow`-based. Generics would permit both a fully owned type as well as `Cow` based. But whatever we do there is orthogonal to...

We’re currently making breaking changes so that’s fine, but we will ideally start wrapping up soon

I don't have time to work on this, sorry, though there are other users who might potentially be interested.

@dishmaker here's a PR that should make `Decode`/`DecodeValue`/ and `Encode`/`EncodeValue` as well as `FixedTag` work for `Cow` (or any other type which impls the appropriate traits): https://github.com/RustCrypto/formats/pull/2093 As soon as...

> I believe usage cfg(nightly) is also a bug - the documentation[2](https://github.com/dalek-cryptography/curve25519-dalek/pull/656#user-content-fn-1-142c9cabbb91de7e9b4fc041a060257e) seems to suggest that features are automatically enabled when compiled They're automatically enabled when compiled because the build...

> I worked around this in my PR but I'm not sure if it's better to fix ed25519 first or to just fix the issue in this crate. @juliusl if...

The `rustsec` crate already uses `thiserror`, although `format_err!` is a pre-`thiserror` relic which should probably just go away Re: `anyhow`, `abscissa` uses `color-eyre` which has an excellent error printer which...

I think this is the culprit: https://github.com/rustsec/rustsec/blob/e41cb98/rustsec/src/repository/git/repository.rs#L109 It should be `with_extension("lock")` that implicitly adds a leading `.`

I'm not terribly worried about scenarios where someone has multiple concurrent versions of `cargo audit` installed because most of the mechanisms for installing it ensure there is only one version...