Tony Arcieri

@baloo why did you mark this as a draft?

Hmm, I also see this includes a lot of unrelated changes it might be nice to break down into separate PRs, like an edition upgrade

Merged `main` but seems I need to cut an `ed25519` release to update the crates

Yes, this crate is somewhat unloved relative to the others, and lacks examples. For reference, the correct trait for decoding `pkcs1::RsaPrivateKey` is [`der::Decode`](https://docs.rs/der/latest/der/trait.Decode.html). With the trait in scope, `pkcs1::RsaPrivateKey::from_der` should...

Yeah, that would be OK, although it might be helpful to still display the inner type name via `DebugStruct` (as sourced via `core::any::type_name`) + `finish_non_exhaustive`

In general perhaps we could use a section on CSRs / PKCS#10 in the toplevel documentation

See ample related discussion in #689 for the encoding side of things. We pretty much went in the opposite direction in #765 and leaned further into the existing hard dependency...

In some other crates, notably `spki` and the latest prereleases of `pkcs8`, we do abstract over the owned and borrowed forms using generics: https://docs.rs/pkcs8/0.11.0-rc.1/pkcs8/struct.PrivateKeyInfo.html This has the following forms, one...

Curious what that benchmark actually looks like. Other implementations may be deferring processing of things `x509-cert` processes eagerly. I'd also be curious what the hotspots in `x509-cert`.

Ideally we could avoid the duplication of a separate type and leverage generics instead, making `CertificateRef` a type alias, similar to how the `pkcs8` crate works: https://docs.rs/pkcs8/0.11.0-rc.6/pkcs8/index.html#types Though a separate...