Tony Arcieri comments

Results 2554 comments of


                                            Tony Arcieri

Cannot parse sha256/sha512 Password-Hashes

FYI, I've written a crate to generically operate on the "Modular Crypt Format": https://docs.rs/mcf/latest/mcf/ I plan on using it to reimplement hash serialization in the `sha-crypt` crate. Once that's done,...

scrypt: relax check on log_n

Can you provide a small, self-contained reproduction of the issue?

Mention in doc comment that `len` field of `scrypt::Params` is used only in `PasswordHasher`

#415 expressed some similar concerns/confusion

Mention in doc comment that `len` field of `scrypt::Params` is used only in `PasswordHasher`

I'm going to change the API to be more like `argon2::Params` so length is no longer a mandatory parameter of `Params`

Mention in doc comment that `len` field of `scrypt::Params` is used only in `PasswordHasher`

#602 is my attempt at addressing this

Mention in doc comment that `len` field of `scrypt::Params` is used only in `PasswordHasher`

Fixed in #602

cpufeatures: requesting support for the newly added target features

TIL there are SHA-512 intrinsics for x86 CPUs. Apparently only for Arrow Lake and Lunar Lake: https://en.wikipedia.org/wiki/Intel_SHA_extensions - `VSHA512RNDS2` - `VSHA512MSG1` - `VSHA512MSG2`

[WIP] Minimum modulus size checks

Down to 35 test failures 😅

[WIP] Minimum modulus size checks

I hope this meets @dignifiedquire's requirements. There are escape hatches for both instantiating keys and keygen, so no functionality is actually removed.

Add support for using VAES instructions for NI parallel operations.

> Regarding adding the vaes feature to the Cargo.toml, rather than using cpufeatures, I couldn't figure out a way to structure the addition of this functionality cleanly otherwise. @silvanshade I'd...