Tony Arcieri

Results 2557 comments of Tony Arcieri

@jonasmalacofilho if you can rebase I added `cargo careful` in #553 which should help spot issues in `unsafe` code

Yeah, Miri is tricky specifically because you can't do anything computationally expensive under it. I think we could potentially gate expensive tests under `#[cfg(not(miri))]` perhaps?

@jonasmalacofilho still need to go through it in detail, but there's nothing I see that's an immediate blocker

I still need to review it. Sorry it's been on the backburner since it's difficult to review due to the use of unsafe code and because we're currently working on...

Apologies for not getting to this yet. I hope to get to it soon, especially as we get closer to final releases. @jonasmalacofilho in the meantime, can you fix the...

@newpavlov IMO it should "just work" when the feature is enabled

Yeah, that's a reasonable concern. I guess my answer there would be to file an issue against those dependencies and have them propagate an off-by-default `parallel` feature rather than enabling...

Please provide a complete reproduction of the problem

The only support for that hash format is in the `sha-crypt` crate. It's a legacy MCF encoding (where MCF isn't really a "standard" but a collection of algorithm-specific encodings), whereas...

We'd need to look into if there are proper PHC encodings for sha-crypt hashes