Tony Arcieri comments

Results 2557 comments of


                                            Tony Arcieri

Strange 404 responses

I get 200 for both of these. Are you sure it's not something server-side?

Implement `safegcd-bounds`

Though perhaps we should just go full binary GCD: #755

I'll +1 @str4d's suggestion that we should follow what we already do with `RsaPublicKey` and have checked `RsaPrivateKey` APIs with short, convenient names which enforce a minimum modulus, and parallel...

Minimum modulus size

I made an attempt at this in #526 but it's breaking the majority of current tests

Minimum modulus size

Merged #526 but ran into some test failures so I reverted. I think a more incremental approach than #526, that first starts with placing limits on keygen, and then applies...

Constant time base64 decoded_len returns InvalidLength on fully valid data

Possibly related to #1716?

Constant time base64 decoded_len returns InvalidLength on fully valid data

Closing as non-reproducible

Constant time base64 decoded_len returns InvalidLength on fully valid data

Note: I confirmed the latest prerelease of `ssh-key` is able to parse this key: ```rust PrivateKey { cipher: None, kdf: None, checkint: Some(3201753955), public_key: PublicKey { key_data: Ed25519(Ed25519PublicKey([220, 182, 180,...

reunite the workspace

@baloo what are the blockers here? I worry about continuing to merge changes to `der` without them being properly tested against the rest of the crates. cc @dishmaker