Tony Arcieri
Tony Arcieri
I took a look at using `KeyInit` in `elliptic-curve`. While it works for e.g. Ed25519 due to clamping, for NIST P-curves we need a fallible constructor to handle the case...
@carloskiki I would probably suggest using PKCS#8 for a common key init for that purpose, e.g. [`pkcs8::DecodePrivateKey`](https://docs.rs/pkcs8/latest/pkcs8/trait.DecodePrivateKey.html). This should already be impl'd everywhere you need it.
Either way it's a serialization of the key as bytes. PKCS#8 just includes algorithm information and is the "standard" private key format (and also offers features like password-based encryption). It...
`KeyInit` can't be used with e.g. `ecdsa::SigningKey` because at the minimum it requires fallibility. Edit: or for that matter, `rsa::pkcs1v15::SigningKey` and `rsa::pss::SigningKey`. Edit again: opened https://github.com/RustCrypto/traits/issues/1897 to discuss a fallible...
It should also be possible to impl the `TryKeyInit` and `Generate` traits that will be in the next release of `crypto-common`
We've been pushing forward with a simplified `signature` v3.0 in @RustCrypto, which would at least entail breaking changes to `ed25519-dalek`. I suggest we do breaking changes for all crates. In...
@reneleonhardt as was stated in the original description of this issue, our SemVer policy allows for major bumps while upgrading dependencies like `rand_core`: https://github.com/dalek-cryptography/curve25519-dalek/tree/main/ed25519-dalek#public-api-semver-exemptions We are volunteers working in our...
@abailly as I just mentioned above, a major blocker for the upgrade is new releases of `digest` and `sha2`, which you can track here: https://github.com/RustCrypto/traits/issues/1571 Hopefully those will be out...
I can't speak to auto-enabling nightly features, but in general I think `nightly` users need to expect that upstream rustc changes can break nightly builds at any time, and all...
I agree that the nightly-related functionality should probably be opt-in (though my comment wasn’t related to that).