Tony Arcieri
Tony Arcieri
@dvdplm it looks like this test is making use of internals / private fields. Can you write it entirely in terms of the public API? Otherwise I can't tell if...
@dvdplm as an alternative to `sage`, you could also compare results with `num-modular`, which is already one of the `dev-dependencies`
@dvdplm that's a good data point to know re: specific sized integers being impacted My best guess would be it's a bug in the `bernstein_yang_nlimbs!` macro which computes the number...
I was able to produce a test failure using the existing test suite by modifying the proptests for modular inversion in `tests/monty_form.rs` to use `U2048` instead of `U256`. I then...
I'm also a little confused why the current calculation for the number of limbs is insufficient, but I'll have to go back through the paper and find where it's defined....
Aha, so the issue is for a given `UNSAT_LIMBS`, we can calculate the maximum allowed size of any modulus or input value in bits as: ``` (UNSAT_LIMBS * 62) -...
Draft PR with a fix here: #610 @dvdplm I'd appreciate it if you could rebase on that and see if it fixed your issues
Yes, I can cut another release soon
Released in v0.6.0-rc.0
Going to close this out, but I'd still be curious in getting some of these tests in if you'd like to resubmit just those