Tony Arcieri

Results 2560 comments of Tony Arcieri

We should probably use something like `crypto-common`'s `KeyInit` for this

> Provide API for people to generate different versions of lockfiles. @weihanglo it already supports this. `Lockfile::version` is consulted at serialization time and used to generate different versions of lockfiles.

A lot of the code has been copied from there. It would be good to follow the same approach they're using.

Sure, that looks potentially useful

FWIW I took a look at `cargo-util-schemas`. It sure would be nice to use several types defined there, like `PackageIdSpec`, `SourceKind` and `GitReference`, however for those in particular they'd be...

I'm busy for the rest of the week but will try to look this weekend

This is OK but it should probably also have the corresponding detached methods on `Decryptor` too