Tony Arcieri

Results 2560 comments of Tony Arcieri

@sgmenda you can express the block size requirement generically by bounding on the `BlockCipher` trait, e.g. ```rust Cipher: BlockCipher ``` One of the advantages of making the underlying cipher generic...

Merged in #587 Thanks @sgmenda! Sorry it took so long!

I think it would be interesting to experiment with an `enum Point` over `AffinePoint` and `ProjectivePoint` which can select the appropriate formulas to use in the https://github.com/RustCrypto/elliptic-curves crates. If this...

@daxpedda yes, that would be the idea, an enum like: ```rust pub enum Point { Affine(AffinePoint), Projective(ProjectivePoint), } ``` Everything else would remain the same

@burdges if you hide the concrete type, you can't know when to select the mixed addition formulas because you've received a mixture of projective and affine inputs

See also: - https://github.com/RustCrypto/utils/pull/821 - https://github.com/rust-lang/rust/issues/117938

FWIW both curve25519-dalek and the @RustCrypto crates impacted by this are written in a way where they have baseline pure Rust implementations that should work fine on softfloat targets, it's...

Yep, from the perspective of all of these crates the AVX2 code is effectively dead on softfloat targets. The problem is that rustc is still trying to compile it anyway....

The reason everything is generic around `Curve`/`CurveArithmetic` is so as an end user you don't need to tediously notate the litany of traits which are needed to generically implement any...

> Those that need to use a specific elliptic curve, and those that want to generically use any elliptic curve. [...] I think the second group of users is quite...