Tony Arcieri

Results 2560 comments of Tony Arcieri

It's hard to have concrete code examples because they'd have to be repeated for each elliptic curve, though I suppose we can add some and copy-and-paste them for each curve,...

Hmm, that branch name `remotes/origin/advertise-ghsa` doesn't exist anymore. Really we should probably do a shallow clone. Can you try deleting `C:\Users\user\.cargo\advisory-db` and see if that fixes the problem?

The `Decode` trait (now) has an associated `Error` type: https://docs.rs/der/0.8.0-rc.0/der/trait.Decode.html#associatedtype.Error If `der::Error` is too limited for a given use case it would be good to switch to a dedicated error...

@str4d was this issue primarily motivated by https://github.com/iqlusioninc/yubikey.rs/issues/580 or something else? The `Decode` trait now has an associated `Error` type, which would be my suggested way of handling any errors...

Regarding speculative decoding and computing the exact position for that, you can use the peek functionality to look ahead without actually modifying the cursor in the buffer, if that's helpful....

Regarding speculative decoding, #1883 made `Reader` cloneable and this is now the method used to implement peeking, i.e. peeking is now implemented as cloning the reader and decoding.

Yes, that sounds great!

Can you try v0.20.1? Edit: oops, didn't mean to close

Can you expound on this: > But this problem is only reproducible when cargo-audit is built in a way that honors the Cargo.lock file. Doing a cargo install ignores Cargo.lock,...

So `cargo install` worked for v0.20.0, works for v0.20.1, but this bug arises with `cargo install --locked` for either v0.20.0 or v0.20.1? Must be a bug in a dependency which...