Tony Arcieri
Tony Arcieri
I’d consider this a breaking change, yes. Before we cut another release though, we should address #1323 which needs breaking changes to fix I believe
The PR has been merged, and the fiat-crypto emitted code should be valid under `const fn` in Rust 1.83 to be released November 28th, 2024. I guess for now I...
Rust 1.83.0-beta.1 has been released with stabilized support for `const_mut_refs`
Great, thanks! If you do accept this change, the generated code will only work under Rust 1.83, which is quite a jump. If there's some way to make it optional,...
> Is there any way to make the generated code condition on Rust version, a la C/C++ preprocessor macros? Not really for this particular case. Every function definition would have...
So turns out I jumped the gun in my hopes the code would be `const fn` compatible. However, I hadn't noticed that the newtypes which were recently added use the...
Here's an example showing the codegen changes needed for `const fn` support: https://github.com/tarcieri/fiat-p521-example/compare/4b4796d30b2e5ae77457d6e8767eb08a7146d641..98d8aa317eea0de8c728526659d9f801af1f0cc2 It's really just adding `const fn` as discussed before, but also accessing the inner array of the...
This was implemented in https://github.com/mit-plv/fiat-crypto/pull/2080
I'd note `mul_bits_be` already has a rather large warning on it. I'm not sure there's much that can be done other than adding a replacement and deprecating it?
Yes, feel free to submit a PR to fix it