signatures icon indicating copy to clipboard operation
signatures copied to clipboard

Incorrect documentation for ecdsa::RecoveryId

Open zigtur opened this issue 1 year ago • 1 comments

At recovery.rs#L45, the documentation indicates:

/// - hi bit (3/4): did the affine x-coordinate of 𝑘×𝑮 overflow the order of /// the scalar field, requiring a reduction when computing r?

However, having hi bit (3/4) is not possible. It should be hi bit (2/3) instead.

zigtur avatar Aug 21 '24 14:08 zigtur

Yes, feel free to submit a PR to fix it

tarcieri avatar Aug 21 '24 14:08 tarcieri

As this issue has been open for a while now, I've created #970 to fix it. @tarcieri please have a look when you're free.

geooner avatar May 15 '25 15:05 geooner