Tony Arcieri

The code that's no longer compiling is part of a somewhat horrible hack to work around [`bindgen`](https://github.com/rust-lang/rust-bindgen) trying to build a binding for `clock_adjtime`. See the lengthy comment here: https://github.com/rpm-software-management/librpm.rs/blob/96e2fde/librpm-sys/src/lib.rs#L35-L66...

> 24% of all crates on crates.io transitively depend on adler, but it has [only 9 direct dependents](https://crates.io/crates/adler/reverse_dependencies). Given that, it would probably make sense to work directly with those...

@oyvindln alternatively you could vendor the relevant code and drop the dependency, since there don’t seem to be that many other users

The only countermeasure for fault attacks we currently provide is the ability to provide supplemental randomness via the [`RandomizedSigner`](https://docs.rs/signature/latest/signature/trait.RandomizedSigner.html) trait. This e.g. avoids potential reuses of `k` for ECDSA when...

I would probably prefer showing how to cache the binary once built using GitHub’s own caching as opposed to recommending some 3rd party action. I’m not familiar with the one...

It can be changed to introspect `AssociatedOid` and include it in the serialized document

You're also free to change it yourself, though it should probably be included by default

I believe this was fixed in #1707

It did in my original implementation. It must've regressed at some point: https://github.com/RustCrypto/elliptic-curves/pull/482/files#diff-7ee5e04f685838d30d3bb56a9c532ffc01948c79f1c7a7faecc989186d803ee1R94-R98

@randombit on the `SigningKey` side of things, this logic should be handling it, eagerly inverting `SigningKey` in this case: https://github.com/RustCrypto/elliptic-curves/blob/a1fabfb/k256/src/schnorr/signing.rs#L124-L130 Are you encountering a codepath where this isn't happening, or...