Tony Arcieri
Tony Arcieri
> While I'm not sure there's a really standard spelling here, the "-or" ending to Encapsulator and Decapsulator looks odd to me, and inconsistent with other crates in this repo,...
> I think it was a mistake in retrospect for Signer to be generic. Are there any examples of any key types that implement signer in more than one way...
`signature` is already at v2.0 and we don't plan on making breaking changes for years. > In theory, the SigningKey could be parameterised instead That would preclude a `SigningKey` being...
Coming back to this after awhile, it would be nice to replace `ml_kem::KemCore` with traits from `kem`. The main things I think are missing right now: 1. A way to...
I've opened a PR to add support for retrieving an encapsulator from an encapsulator using an associated type on `Decapsulator` (i.e. item number 1 above): https://github.com/RustCrypto/traits/pull/2055
Here's an additional PR to use `KeyInit` for initialize types that impl the `Decapsulate` trait, which also handles key generation: https://github.com/RustCrypto/traits/pull/2056
It would probably make sense to figure out a common naming convention we can use for `rsa` and `dsa` which allows insecure cryptography
Related: https://github.com/RustCrypto/RSA/issues/445
Yeah, if we support this it would be better to have an explicit API for it (which could still be feature-gated)
We can probably remove this check entirely when the `rsa` crate enforces a minimum modulus size (RustCrypto/RSA#445), which is currently proposed to be 1024-bits. @Eugeny would that be good enough...