milen
milen
do not merge, there are pending issues I need to resolve until Astrid can start (once it does we can use this to benchmark current download blocks code)
Do after: https://github.com/ledgerwatch/erigon/issues/11031 There are a bunch of private constructors in: - polygon/p2p - polygon/sync - potentially others within the polygon/ package That exist only because we need to pass...
we have a bunch of constructors in polygon/p2p,sync,heimdall packages that return interfaces this goes against go's idea of always returning/exporting concrete structs and defining interfaces at consumers - change all...
Relates to a group of issues related to invalid json responses in our trace_* and debug_* APIs in error cases due to the fact we use json streaming: - https://github.com/ledgerwatch/erigon/issues/10376...