Tanyo Kwok

Results 41 comments of Tanyo Kwok

> can you please plug in the MHLO backend into the end-to-end tests in our CI Thanks for reminding me @silvasean. I will try to figure out how to add...

@pashu123 Can you have a glance at my code? Why is the data type of `torch.roll` output unknown in the e2e test? ![image](https://user-images.githubusercontent.com/8392447/183574680-10562c39-f0a0-4a1f-805b-e76b00fcfa39.png)

@pashu123 @silvasean After rebasing the latest main branch codes, all the tests are passed. Do you have any other comments?

Can we add some file check unit tests for the pass?

@ashay @silvasean I have added a patch: https://reviews.llvm.org/D130069; please review for me.

Is there any end-to-end examples for `V-Diffusion`?

Sure! This is a good suggestion. I will try it out recently.

As @silvasean mentioned https://github.com/llvm/torch-mlir/pull/1025#issuecomment-1178465875 before. This PR adds the MHLO end-to-end unit tests to CI. It lowers MHLO to Linalg and run it on Linalg-On-Tensors backend. Please review for me...

@silvasean I can't reproduce the CI failure locally with the following environments: ``` Collecting environment information... PyTorch version: 1.13.0.dev20220814+cpu Is debug build: False CUDA used to build PyTorch: None ROCM...

> Once that's out, could you try to rebase on that and then run these tests locally? @sjain-stanford Thanks! I would love to do that.