torch-mlir icon indicating copy to clipboard operation
torch-mlir copied to clipboard
verified publisher icon llvm

[MHLO] Add configurable op decomposition rules

Open Vremold opened this issue 3 years ago • 3 comments

See RFC #999 We register some options in TorchLoweringPipeline and DecomposeComplexOpsPass to make the decomposition rules configurable.

Co-authored-by: Bairen Yi [email protected] Co-authored-by: Jiawei Wu [email protected] Co-authored-by: Tianyou Guo [email protected] Co-authored-by: Xu Yan [email protected] Co-authored-by: Ziheng Jiang [email protected]

Vremold avatar Aug 08 '22 07:08 Vremold

Can we add some file check unit tests for the pass?

tanyokwok avatar Aug 08 '22 07:08 tanyokwok

Can we add some file check unit tests for the pass?

Done.

Vremold avatar Aug 08 '22 08:08 Vremold

I have some specific opinions about how we want to do this -- I am on vacation the rest of this week, but after #1165 lands this was the next thing I was going to work on (and this PR creates a nasty merge conflict). If you can wait for a week or so I would be happy to implement this.

That's okay. I can wait for that.

Vremold avatar Aug 09 '22 01:08 Vremold

There is a better choice in PR #1242 . This PR is useless and closed.

Vremold avatar Aug 19 '22 02:08 Vremold