Tom Nabarro
Tom Nabarro
> From what In understand with Jenkins logs, the functional tests are not compliant with the new CLI syntax. FMHO, functional tests adaptation should be done in this PR to...
> Stepping back a bit, I agree with the general goal here, which is to improve the command surface. Currently, we have the following: > > ``` > [prepare command...
> I'm not disagreeing that the changes here are an improvement; I'm just saying that if we're going to invest the engineering time in making a change (including updating all...
> Perhaps we should rename `scm` to `pmem` in the user-visible command surface? We reference both, but I think it might be clearer to new users if we pick one...
> Generally looks good. I played around with the PR on my wolf node but it doesn't have pmem. I noticed that the nvme commands don't seem to accept any...
@mjmac added syntax tests, please take a look
> Latest commits look good. One minor typo to fix. > > Would be good to get some more input from e.g. @Michael-Hennecke on the command updates before we land....
Note as per mjmac's request, the commands are now "pmem" not "scm". After your discussion with @johannlombardi the request is to change this back to "scm". So to be clear...
> > Confirmed, we should **not** change "scm" to "pmem". Let's keep the "scm" nomenclature that has been used so far (and which is agnostic to any specific hardware implementation...
going to push the spelling corrections and some of the doc syntax corrections into the subsequent https://github.com/daos-stack/daos/pull/10022 PR if that's okay