Tom Nabarro
Tom Nabarro
> Please, could you tell me which part of the code has been changed from the cherry-pick. There were quite a few changes due to the difference in the 2...
> Is this patch necessary for 2.4? Given its size and complexity, it seems somewhat risky. If I understand correctly, the main goal is to correctly avoid failures in bdev...
Closing as per @mjmac 's suggestion
Note to reviewers, it may be easier to review individual commits which should indicate reasons for the changes.
apologies for the force push, was hard to avoid with the rebase
> @tanabarr: I'm really having a hard time with the global variables... I think it's asking for a lot of trouble with flaky tests, particularly down the road when other...
2 most recent CI runs with `Features: control` both failed with a single intermittent failure unrelated to this change: - https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13994/21/tests/ https://daosio.atlassian.net/browse/DAOS-14585 - https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13994/20/tests https://daosio.atlassian.net/browse/DAOS-15649 Requesting forced landing to avoid...
> Yeah, after applying this patch, I got the same errors when setting `self_heal` to `exclude,rebuild`: > > ``` > bash-5.1$ ~/daos/install/bin/dmg -o ~/daos_control.yml -i pool set-prop p0 self_heal:exclude >...
I think this is ready to land, it's passed all CI hardware test stages after multiple run from stage tries. NLT failures look unrelated and approvals have been done. Requesting...
@daos-stack/daos-gatekeeper can this be landed given we've got all green on CI and NLT is unrelated? otherwise please let me know if I need to rerun. TIA