Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

Deprecation warnings are silenced while time is mocked

Done. https://github.com/adamchainz/time-machine/issues/446.

Replace proc-macro-error with proc-macro2-diagnostics

If you can close it, maybe you can also review and accept it?

Replace proc-macro-error with proc-macro2-diagnostics

Ack. Salvaged some useful stuff into #542 + added GitHub CI.

build(deps): update object requirement from 0.34 to 0.35 in the production-dependencies group

@dependabot merge

fix(aya): Fix panic when creating map on custom ubuntu kernel

I don't love that this has no test coverage and uses `Result::ok`. Papering over errors is not a good practice.

build(deps): bump DavidAnson/markdownlint-cli2-action from 15 to 16 in the production-dependencies group

@dependabot merge

fix(aya): Fix panic when creating map on custom ubuntu kernel

Pushed an update to reduce the diff a bit. @alessandrod LGTY?

Tcx

> @tamird for some reason, I can't respond directly to your latest comments. So, I'll respond by adding my own comments on the code you reference. can you use reviewable?

Tcx

Reminder to please squash on or before merge.

feature request: snapshot name suffix

There's another issue with not being able to specify a suffix: - If my comparisons are as written above (v2 then v1) then when I add a new version it'll...