Tamar Grey

Results 31 comments of Tamar Grey

Another option if we wanted to let users define the boolean values would be with parameters to the `Boolean` logical type like `Boolean(true_value='yes', false_value='no')` that, when present, confirm that only...

Thinking a little more about this: If we eventually wanted to update Woodwork's type inference to infer columns with these kind of values as `Boolean` (which is another part about...

Delayed because of problems outlined in this draft PR: https://github.com/alteryx/featuretools/pull/1788

@gsheni Yeah, I think that makes sense

Can you add RollingOutlierCount to the `test_rolling_primitives_non_uniform` test? (Or, if it needs a slightly different handling, make a separate test for it like `test_rolling_std_non_uniform` and `test_rolling_trend_non_uniform`)

I can't officially approve bc I'm the original author of this PR 🙈 , but this looks good to me!

This issue should include looking into tsfresh primitives and determining which would be useful to include as rolling gap primitives once #1756 is completed.

Adding the fourier transform tsfresh primitives as rolling transform primitives may be useful for time series (@freddyaboulton, @ParthivNaresh ) - https://github.com/alteryx/featuretools-tsfresh-primitives/blob/main/featuretools_tsfresh_primitives/primitives/fft_aggregated.py - https://github.com/alteryx/featuretools-tsfresh-primitives/blob/main/featuretools_tsfresh_primitives/primitives/fft_coefficient.py

@thehomebrewnerd Yep, that definitely could be a possibility. Might just be worth examining why we've decided to add attributes to Woodwork instead of adding to the metadata (for things like...

Hi @jacktang, Would you be able to clarify how you see the relationships between these different dataframes as well as the multiple time series in the problem you're trying to...