featuretools icon indicating copy to clipboard operation
featuretools copied to clipboard

Add rolling outlier count primitive

Open tamargrey opened this issue 2 years ago • 3 comments

closes #1804

tamargrey avatar Jun 21 '22 19:06 tamargrey

@tamargrey @ozzieD Should we wait until this issue (https://github.com/alteryx/featuretools/issues/2213) is completed before revisiting this?

gsheni avatar Aug 02 '22 17:08 gsheni

@gsheni Yeah, I think that makes sense

tamargrey avatar Aug 02 '22 17:08 tamargrey

@tamargrey https://github.com/alteryx/featuretools/issues/2213 has been completed so we can revisit this PR.

gsheni avatar Aug 08 '22 18:08 gsheni

Codecov Report

Merging #2129 (29800d6) into main (cfa19d1) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         310      311    +1     
  Lines       19773    19814   +41     
=======================================
+ Hits        19660    19701   +41     
  Misses        113      113           
Impacted Files Coverage Δ
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.34% <ø> (ø)
...mitives/standard/transform/time_series/__init__.py 100.00% <100.00%> (ø)
...ard/transform/time_series/rolling_outlier_count.py 100.00% <100.00%> (ø)
featuretools/tests/conftest.py 100.00% <100.00%> (ø)
...ls/tests/primitive_tests/test_rolling_primitive.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 27 '22 22:10 codecov[bot]

Can you add RollingOutlierCount to the test_rolling_primitives_non_uniform test? (Or, if it needs a slightly different handling, make a separate test for it like test_rolling_std_non_uniform and test_rolling_trend_non_uniform)

tamargrey avatar Oct 31 '22 19:10 tamargrey

@sbadithe I believe this should be good to go (once the lint issue is fixed).

gsheni avatar Nov 01 '22 15:11 gsheni

I can't officially approve bc I'm the original author of this PR 🙈 , but this looks good to me!

tamargrey avatar Nov 02 '22 13:11 tamargrey