Tamar Grey
Tamar Grey
This may also allow us to remove `LogicalType._get_valid_dtype` and just use `LogicalType.primary_dtype` (though now that there's no backup dtype, maybe we should change the name of "primary_dtype")
I think I'd vote for not having `Float64Dtype` at all over having a `Double` and `DoubleNullable`. Maybe there's another name that better describes the relationship between the two potential Logical...
Another idea to achieve this kind of fallback behavior would be to let woodwork users specify how logical types should fall back. For example, letting users who can't use the...
The original pandas issue (https://github.com/pandas-dev/pandas/issues/40729) that caused us to add this change is fixed, though the change mentioned in this issue no longer seems to be present. So this issue...
Correct, I was more saying that I think the workaround I created this issue about may no longer be present (it's no longer in that test on woodwork main), in...
Would there ever be lists of floats or strings? Say you had something like "first letter of each word". Maybe we allow some form of stacking of logial types? Like...
@thehomebrewnerd This appears to have been fixed! Running your code to reproduce on main works just fine, and it produces the errors described here in evalml 0.57.0 (which was just...
Okay decided to do the git bisect today in he end: It seems that fc982d77f015a8040effc1a0d58fad4eaa0ade6a is the first commit that fixes this bug. My guess is that something about explicitly...
Found the culprit: https://github.com/alteryx/evalml/commit/fc982d77f015a8040effc1a0d58fad4eaa0ade6a#diff-1839ccf15077fbf3e37f6e638f66745f6f354cec3df273e2cc9b7b3e40f3863dL261 We were previously only transforming lagged `Categorical` logical type columns to be doubles (because `TimeSeriesFeatureizer._get_categorical_columns` does `X.ww.select(["categorical", "boolean"]`, which it still does, so it's probably worth...
> @tamargrey Still trying to digest this information just a but, but how can we do a categorical to double conversion reliably since categories don't have to be numeric? @thehomebrewnerd...