Soroosh Taefi comments

Results 55 comments of


                                            Soroosh Taefi

trafficstars

Browser back should restore body like it was before

@timbo86 I can say this is not a bug since it works as intended. However, there can be some arguments about the default behavior of the dialog while navigating via...

UIInitEvent should have the current path

@ImOlli maybe not be exactly what you want, but you can use the following to get the current URL basically anywhere in the code: ``` UI.getCurrent().getPage().fetchCurrentURL(url -> System.out.println(url)); ```

test: use npm instead of pnpm in ITs

> What is the performance impact of this? This was more of a test to see whether the repo is npm friendly ;) I expect to see some timeouts and...

test: use npm instead of pnpm in ITs

I Agree, the original intention was to see the impact of changing it to npm, but we can actually try this in practice later.

onload event not working when loading JavaScript to browser

@letrthang could you please elaborate more on what you want to achieve here? Do you have a JS file called "clientLocation.js" that contains the code to register a listener for...

Google App Engine deployments causes NPE

@dmitrilc thanks for creating this issue. Could you try changing the instance to F2 as mentioned in this blog post: https://foojay.io/today/how-to-deploy-a-vaadin-application-to-google-cloud-app-engine/

Page.setLocation() stops the application if navigation was canceled

As mentioned in the issue `public void setLocation(String uri)` method of `Page.java` is doing the following: ``` public void setLocation(String uri) { this.open(uri, "_self"); } public void open(String url, String...

[Grid] lazy loading refreshItem will pass PageSize = Integer.MAX_VALUE

@letrthang I could not find the codes from your screenshots neither in `GridLazyDataView` nor `AbstractLazyDataView`. Also, I couldn't find loading all of the items in the lazy-loading related classes. Am...

onDetach() is not called after page closed and hearbeats stopped, even for a long time

@bardyamomeni thanks for creating this issue. If "when a page is closed" means closing the browser's tab, I think this might not be exactly a bug, but more of an...

onDetach() is not called after page closed and hearbeats stopped, even for a long time

Another workaround (before the functionality is added officially to the platform) can be something like: https://cookbook.vaadin.com/notice-closed to take control of what should happen when the user closes a browser tab....