flow icon indicating copy to clipboard operation
flow copied to clipboard

test: use npm instead of pnpm in ITs

Open taefi opened this issue 1 year ago • 4 comments

Description

As the default package manager is npm ITs should be also validated by npm instead of pnpm. Using pnpm can still be considered as an option to improve the build and test time on CI.

taefi avatar Aug 03 '22 13:08 taefi

Unit Test Results

   917 files  ±0     917 suites  ±0   52m 46s :stopwatch: + 1m 50s 6 008 tests ±0  5 954 :heavy_check_mark:  - 1  53 :zzz: ±0  1 :x: +1  6 220 runs   - 3  6 159 :heavy_check_mark:  - 4  60 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit d9aa8048. ± Comparison against base commit 99c7ffbd.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 03 '22 14:08 github-actions[bot]

What is the performance impact of this?

Artur- avatar Aug 11 '22 07:08 Artur-

What is the performance impact of this?

This was more of a test to see whether the repo is npm friendly ;) I expect to see some timeouts and failures in the tests, and the performance impact can be measured better after a successful build.

taefi avatar Aug 11 '22 11:08 taefi

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Aug 11 '22 11:08 sonarcloud[bot]

@taefi I propose to close this PR, some tests are failing and probably there is no big profit for us to change the build tool in tests.

mshabarov avatar Aug 29 '22 11:08 mshabarov

I Agree, the original intention was to see the impact of changing it to npm, but we can actually try this in practice later.

taefi avatar Aug 29 '22 12:08 taefi