Tadeusz Sośnierz
Tadeusz Sośnierz
With this applied, `ircToHtml()` works as well and I can see it working Hexchat -> Matrix: ```diff diff --git a/src/irc/formatting.ts b/src/irc/formatting.ts index 136b7f18..e3d4d2e6 100644 --- a/src/irc/formatting.ts +++ b/src/irc/formatting.ts @@ -262,13...
Fixed it up in https://github.com/thomwiggers/matrix-appservice-irc/pull/1
Looks good, but we'll need a signoff and a changelog entry: see https://github.com/matrix-org/matrix-appservice-bridge/blob/develop/CONTRIBUTING.md#%EF%B8%8F-pull-requests
> just to confirm: does this mean to say MSC3916 instead of MSC3910? 3910 is a closed, but related, MSC. Yes, correct - I copied the old number from the...
> Is a release with this planned before Synapse defaults to disallowing unauthenticated media? Yes, that's the plan.
> This looks good on the whole, only a few suggestions. Should we have tests though? We have some tests covering the case of "do these URLs look like MediaProxy's...
> I'd love to see his PR merged. Any way of pre-configuring the default output would be of interest. Ideally, a `dufrc` file and environment variables. But at least one!...
> It's probably a good idea to stick to XDG standards for the config file location. Check out https://github.com/muesli/go-app-paths. Isn't that what https://pkg.go.dev/os#UserConfigDir does? Ah, not quite – doesn't fallback...
Switched it over to go-app-paths, done the docs (manpage and README).
Bump. Is there anything blocking this still?