Tadeusz Sośnierz
Tadeusz Sośnierz
I cannot reproduce it. I tried registering a username with nickserv, with `foo'@bar` in a password, which worked fine. Then `!storepass foo'@bar` and `!reconnect` authenticated me successfully. This was tested...
I think this is okay to merge, even without the changelog (it's a very internal change afaic).
It seems like we already have that functionality since 705e8f9b9 (part of https://github.com/matrix-org/matrix-appservice-irc/pull/1156)
> I suppose the jury is out on whether it's _useful_ to have this This is what it goes down to, yeah. If it'll end up the giving the false...
Seems fine to me – I wonder if we want to actually migrate the old passwords though, to be able to cut out that code path. @Half-Shot?
Converting to markdown would be a sensible fallback for `+c` channels, for non-`+c` I think it makes sense to keep it the way it is.
Absolutely :)
It's worth considering updating our matrix-appservice-bridge here and dropping NeDB while at it – we'd need to support a DB migration though.
> What's needed to make that test pass? It needed the default timeout increased, 2 seconds was not enough to apply DB migrations. Should be good now.
Note: this is RTM-only, as webhooks do not support multipart messages in the first place.