Tadeusz Sośnierz
Tadeusz Sośnierz
I cannot reproduce it anymore, even on `develop` EDIT: Actually, `
Is this still happening? I cannot reproduce it – it Just Works on RTM, and using webhooks it still bridges the URL to the file.
Not related to #782, I'd assume a puppeting problem similar to https://github.com/matrix-org/matrix-appservice-slack/issues/481. Will look into this further.
I tried to reproduce it and cannot; messages with link previews come through, in both RTM and webhook mode. The message would get quietly dropped by the bridge if it...
Fixed in #781
Changelog is probably failing this: https://github.com/matrix-org/matrix-appservice-irc/blob/develop/scripts/check-newsfragment#L32
> Looks like an issue with the CI check: > > ``` > 2024-08-01T12:26:57.7333573Z +++ �[32mChecking newsfragment�[m > 2024-08-01T12:26:58.1581840Z Looking at these files: > 2024-08-01T12:26:58.1582740Z ---- > 2024-08-01T12:26:58.1583756Z 1. /home/runner/work/matrix-appservice-irc/matrix-appservice-irc/changelog.d/1812.bugfix...
Possibly fixed by https://github.com/matrix-org/matrix-appservice-slack/pull/781 – we were habitually eating the first newline in bridged messages, which would affect code blocks too.
Plenty of test regressions here. Tricky to track down, since we're changing so many things at once. Test "should allow arbitrary IRC commands to be issued" fails presumably due to...
One linting error away and the changelog, and we should be good to go