Tac Tacelosky

Results 545 comments of Tac Tacelosky

What do you think of bumping to Symfony 6.1 (which would obviously require PHP 8.1)? If we're going to fix PHPStan errors to have an app that shows best practices,...

Oh, I see, it's a magic method. Can we explicitly define it?

Brainstorming -- what do you think of removing the magic methods and simply calling the methods directly? That is, $web->links() instead of $web->links

Sigh. Version 6 no longer including a manager, so using this requires a cache and mechanism for fetching and storing the rules. It's not too difficult, but it's not a...

OK. There are 2 approaches. The easiest is to download the rules file, add it to the repo, and then load it. Of course, the rules will become stale. The...

Since you've tagged this as a new version, can we also bump to PHP8?

Also, I'd like to migrate this to psr-4, and separate the classes into their own files. Or perhaps you should do that, it's likely a BC.

I started down the rabbit hole... If phpscraper needs a cache for the domain parse, a CacheInterface cache should probably be injected. But that means the phpscaper should itself be...

Hi, James, any chance you can take a look at this? In particular, I don't know why the search test fails, I removed the 2 tests, but obviously that's not...

I just did this for another bundle today, it's pretty easy: https://github.com/bestit/flagception-bundle/pull/98 Is this bundle still being maintained? The PR I've submitted here hasn't been acknowledged. The other solution is...