PHPScraper
PHPScraper copied to clipboard
charset in headers method
Is this method used? Where is charset() defined?
/**
* Get the header collected as an array
*
* @return array
*/
public function headers()
{
return [
'charset' => $this->charset(),
'contentType' => $this->contentType(),
'viewport' => $this->viewport(),
'canonical' => $this->canonical(),
'csrfToken' => $this->csrfToken(),
];
}
Oh, I see, it's a magic method. Can we explicitly define it?
Brainstorming -- what do you think of removing the magic methods and simply calling the methods directly?
That is, $web->links() instead of $web->links
As mentioned in the other ticket, I like my magic methods ;)